Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review95611 --- src/examples/java/TestPersistentVolumeFramework.java (lines 535 - 5

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

On Aug. 14, 2015, 10:28 p.m., haosdent huang wrote: > > Again, sorry it's taken so long to get round to doing this review and s > > many thanks for doing this! > > > > I've only got halfway through, I'll try my best to do more in the next few > > days, less craziness (here's to hoping, any

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On Aug. 14, 2015, 10:28 p.m., Marco Massenzio wrote: > > [mmm turns out that it matters WHICH boxes you put your general comments in :) - copied here, as they make sense *before* the nitpicking that follows] Again, sorry it's taken so long to get round to doing this review and s many th

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review95473 --- src/examples/java/TestPersistentVolumeFramework.java (line 34)

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review88697 --- Patch looks great! Reviews applied: [9] All tests passed. - M

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:57 a.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, lines 529-542 > > > > > > Please consider using Apache Commons CLI instead: > > https://commons.apache.o

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 9:42 a.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review88691 --- Patch looks great! Reviews applied: [9] All tests passed. - M

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 5:37 a.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, line 239 > > > > > > unless I'm mistaken and this is a unit test (is it?) can we please > > rename this

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 21, 2015, 5:17 a.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 4:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more commen

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review86956 --- Patch looks great! Reviews applied: [9] All tests passed. - M

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated June 7, 2015, 8:10 a.m.) Review request for mesos, Jie Yu and Vinod Ko

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, line 239 > > > > > > unless I'm mistaken and this is a unit test (is it?) can we please > > rename this

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, line 110 > > > > > > here too here could not remove because `j` is used in `remains.set(j, newRemain);`,

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > src/examples/java/TestPersistentVolumeFramework.java, line 29 > > > > > > as this is an "example" framework, it'd be great if it could have > > (extensive) jav

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote: > > This is great -sorry it took so long to get to do a review. > > > > Thanks for doing it, I'm quite looking forward to using it to learning more > > about the Persistent Framework :) > > it would be great if we could have a bit more comme

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review86113 --- This is great -sorry it took so long to get to do a review. Thanks

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 26, 2015, 7:10 a.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review81595 --- Patch looks great! Reviews applied: [9] All tests passed. - M

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 6:07 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 6:05 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 1:25 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 1:23 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 10:17 a.m.) Review request for mesos and Jie Yu. Bug