Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-06-04 Thread Benjamin Hindman
> On May 18, 2015, 6:20 p.m., haosdent huang wrote: > > configure.ac, line 650 > > > > > > Should we change acx_pthread.m4 to ax_pthread.m4 here? > > James Peach wrote: > Updated the patch to alter the comments to

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review86598 --- Ship it! Ship It! - Benjamin Hindman On May 1, 2015, 4:02 p.m.,

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-24 Thread haosdent huang
> On May 18, 2015, 6:31 p.m., haosdent huang wrote: > > m4/ax_python_devel.m4, line 268 > > > > > > Could not understand why need add conf('SYSLIBS')) here? Could you > > explain this? Thank you > > James Peach wrote

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-19 Thread James Peach
> On May 18, 2015, 6:20 p.m., haosdent huang wrote: > > configure.ac, line 650 > > > > > > Should we change acx_pthread.m4 to ax_pthread.m4 here? Updated the patch to alter the comments too. - James --

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-19 Thread James Peach
> On May 18, 2015, 6:31 p.m., haosdent huang wrote: > > m4/ax_python_devel.m4, line 268 > > > > > > Could not understand why need add conf('SYSLIBS')) here? Could you > > explain this? Thank you ``ax_python_devel.m4`

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review84185 --- m4/ax_python_devel.m4

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review84183 --- configure.ac

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review82269 --- Patch looks great! Reviews applied: [33753] All tests passed. - M

Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-01 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/ --- Review request for mesos. Bugs: MESOS-2659 https://issues.apache.org/jira/b