Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread James Peach
On June 4, 2015, 3:22 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/configure.ac, line 692 https://reviews.apache.org/r/33850/diff/2/?file=950418#file950418line692 I think you meant != here. ;-) How did this pass for you!? That for fixing that. I think what happened was that

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/#review86628 --- 3rdparty/libprocess/configure.ac

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/configure.ac, line 694 https://reviews.apache.org/r/33850/diff/2/?file=950418#file950418line694 s/Mesos/libprocess/ I took care of this fix for you James before committing. Thanks! - Benjamin

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote: Just a heads up, you went from the +2 indentation in this file to +4 when you moved stuff around. I fixed it for you, but please keep the style consistent in the future, thanks! - Benjamin

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/#review86602 --- Ship it! 3rdparty/libprocess/configure.ac