On May 11, 2015, 3:49 p.m., Jie Yu wrote:
src/slave/monitor.cpp, line 126
https://reviews.apache.org/r/33876/diff/3/?file=955511#file955511line126
Hum, this looks like a bug to me? Since you capture `containerId` by
reference, what if by the time `onFailed` is called, the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/#review83645
---
Ship it!
Ship It!
- Jie Yu
On May 12, 2015, 8:55 p.m., Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/
---
(Updated May 12, 2015, 1:55 p.m.)
Review request for mesos, Jie Yu and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/#review83292
---
src/slave/monitor.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/#review82627
---
Patch looks great!
Reviews applied: [33875, 33876]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33876/
---
Review request for mesos and Vinod Kone.
Repository: mesos
Description