Re: Review Request 34138: AppC hash computation.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review141466 --- Closing this review due to inactivity. Please see our

Re: Review Request 34138: AppC hash computation.

2015-07-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review91145 --- src/slave/containerizer/provisioners/appc/hash.hpp (line 40)

Re: Review Request 34138: AppC hash computation.

2015-07-09 Thread Vinod Kone
On July 9, 2015, 6:47 p.m., Vinod Kone wrote: Also, we need tests!? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review91145

Re: Review Request 34138: AppC hash computation.

2015-07-07 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/ --- (Updated July 7, 2015, 12:42 p.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 34138: AppC hash computation.

2015-07-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review90791 --- 1. Agree that this is useful as a utility in libprocess. Not much

Re: Review Request 34138: AppC hash computation.

2015-07-07 Thread Jiang Yan Xu
On July 7, 2015, 3:56 p.m., Jiang Yan Xu wrote: 1. Agree that this is useful as a utility in libprocess. Not much overhead to move it over right? 2. It feels like something that could be exposed as a function rather than class, maybe a TODO. OK I realized that doing the

Re: Review Request 34138: AppC hash computation.

2015-05-18 Thread Ian Downes
On May 18, 2015, 4:37 p.m., Chi Zhang wrote: push the implementation down to stout? is it possible to swap to use devel packages for hashing in the future? Not to stout because it's asynchronous but perhaps to libprocess. - Ian

Re: Review Request 34138: AppC hash computation.

2015-05-18 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review84195 --- push the implementation down to stout? is it possible to swap to