Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review141519 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review113545 --- Can we close this now? I don't think this is relevant anymore. - T

Re: Review Request 34140: AppC image store

> On May 27, 2015, 4:10 p.m., Paul Brett wrote: > > src/slave/containerizer/provisioners/appc/store.cpp, line 267 > > > > > > Why not do the decompress, hash & untar as a pipeline to reduce disk > > usage? > > Ian Do

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review91989 --- Not necessary to be done in this review but we should allow `putting

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review90873 --- src/slave/containerizer/provisioners/appc/store.hpp (lines 22 - 33)

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review90954 --- src/slave/flags.cpp (line 74)

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- (Updated July 7, 2015, 12:43 p.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- (Updated June 22, 2015, 9:51 a.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34140: AppC image store

> On May 27, 2015, 4:10 p.m., Paul Brett wrote: > > src/slave/containerizer/provisioners/appc/store.cpp, line 138 > > > > > > And log the error? This is standard clean up, errors will be logged by any preceeding compo

Re: Review Request 34140: AppC image store

> On May 26, 2015, 11:28 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/appc/store.cpp, line 79 > > > > > > Check exists first? os::mkdir() ignores EEXIST so won't return an error if it already exis

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review85456 --- Disk usage by the store is currently unbounded. Do we need to add t

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review83840 --- src/slave/containerizer/provisioners/appc/store.hpp

Re: Review Request 34140: AppC image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- (Updated May 26, 2015, 11:25 a.m.) Review request for mesos, Chi Zhang, Paul Br

Re: Review Request 34140: Appc image store

> On May 18, 2015, 4:38 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, line 116 > > > > > > Looks like this is a global store for all images. Would it make sense > > to make sure at mo

Re: Review Request 34140: Appc image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review84233 --- src/slave/containerizer/provisioners/appc/store.hpp

Review Request 34140: Appc image store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.