Re: Review Request 34193: Refactored common functionality into FlagsBase

2015-05-30 Thread Marco Massenzio
On May 30, 2015, 12:21 a.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 89-121 https://reviews.apache.org/r/34193/diff/6/?file=973992#file973992line89 The wrapping here is still weird. I would just ask benh to format with

Re: Review Request 34193: Refactored common functionality into FlagsBase

2015-05-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/#review85843 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 34193: Refactored common functionality into FlagsBase

2015-05-28 Thread Marco Massenzio
On May 28, 2015, 11:45 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 517 https://reviews.apache.org/r/34193/diff/5/?file=972154#file972154line517 This looks like a duplicated test with the 'Usage' test above? great catch! modified to

Re: Review Request 34193: Refactored common functionality into FlagsBase

2015-05-28 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/ --- (Updated May 29, 2015, 12:51 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34193: Refactored common functionality into FlagsBase

2015-05-26 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/ --- (Updated May 26, 2015, 8:47 p.m.) Review request for mesos, Benjamin Hindman