Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Niklas Nielsen
On June 3, 2015, 4:26 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 344-345 https://reviews.apache.org/r/34632/diff/2/?file=977215#file977215line344 Can you explain why you want to start receiving/acting on corrections even before the slave is recovered? How do you kill a

Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86677 --- Ship it! Ship It! - Jie Yu On June 4, 2015, 5:42 p.m., Niklas

Re: Review Request 34632: Added QoS Controller in slave

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86501 --- LGTM overall. Just one place (regarding the time when we start to

Re: Review Request 34632: Added QoS Controller in slave

2015-06-02 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/ --- (Updated June 2, 2015, 9:28 p.m.) Review request for mesos, Bartek Plotka, Jie

Review Request 34632: Added QoS Controller in slave

2015-05-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/ --- Review request for mesos. Repository: mesos Description --- Wired up