Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34956/#review86313 --- Ship it! Ship It! - Paul Brett On June 2, 2015, 10:04 p.m., Jie

Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Jie Yu
On June 2, 2015, 10:40 p.m., Paul Brett wrote: src/linux/routing/queueing/discipline.hpp, line 39 https://reviews.apache.org/r/34956/diff/1/?file=976864#file976864line39 Should config be optional? Jie Yu wrote: We still need a Config struct for each type of qdisc so that the

Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34956/#review86336 --- src/linux/routing/queueing/discipline.hpp

Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Jie Yu
On June 2, 2015, 10:40 p.m., Paul Brett wrote: src/linux/routing/queueing/discipline.hpp, line 39 https://reviews.apache.org/r/34956/diff/1/?file=976864#file976864line39 Should config be optional? We still need a Config struct for each type of qdisc so that the template

Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34956/ --- Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.