Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Jie Yu
On June 2, 2015, 11:09 p.m., Paul Brett wrote: src/linux/routing/queueing/internal.hpp, line 143 https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143 Not your problem, but we really should either explain why we have to increment the reference counter here but

Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Paul Brett
On June 2, 2015, 11:09 p.m., Paul Brett wrote: src/linux/routing/queueing/internal.hpp, line 143 https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143 Not your problem, but we really should either explain why we have to increment the reference counter here but

Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34957/ --- Review request for mesos, Chi Zhang, Ian Downes, Paul Brett, and Cong Wang.

Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Jie Yu
On June 2, 2015, 11:09 p.m., Paul Brett wrote: src/linux/routing/queueing/internal.hpp, line 143 https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143 Not your problem, but we really should either explain why we have to increment the reference counter here but

Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34957/#review86305 --- Ship it! Ship It! - Paul Brett On June 2, 2015, 10:05 p.m., Jie