Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Mark Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
---

(Updated July 6, 2015, 6:46 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
---

Rename OptionT::get(const T _t) to getOrElse() and refactor original 
functions (libprocess)


Diffs
-

  3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579 

Diff: https://reviews.apache.org/r/35286/diff/


Testing
---

make check


Thanks,

Mark Wang



Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review90537
---

Ship it!


Ship It!

- Joris Van Remoortere


On July 6, 2015, 6:46 p.m., Mark Wang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35286/
 ---
 
 (Updated July 6, 2015, 6:46 p.m.)
 
 
 Review request for mesos and Joris Van Remoortere.
 
 
 Bugs: MESOS-2800
 https://issues.apache.org/jira/browse/MESOS-2800
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Rename OptionT::get(const T _t) to getOrElse() and refactor original 
 functions (libprocess)
 
 
 Diffs
 -
 
   3rdparty/libprocess/src/process.cpp 
 883776a6d87f3f14d04e2d574b0e0baa469af579 
 
 Diff: https://reviews.apache.org/r/35286/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Mark Wang
 




Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review90546
---

Ship it!


Ship It!

- Benjamin Hindman


On July 6, 2015, 6:46 p.m., Mark Wang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35286/
 ---
 
 (Updated July 6, 2015, 6:46 p.m.)
 
 
 Review request for mesos and Joris Van Remoortere.
 
 
 Bugs: MESOS-2800
 https://issues.apache.org/jira/browse/MESOS-2800
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Rename OptionT::get(const T _t) to getOrElse() and refactor original 
 functions (libprocess)
 
 
 Diffs
 -
 
   3rdparty/libprocess/src/process.cpp 
 883776a6d87f3f14d04e2d574b0e0baa469af579 
 
 Diff: https://reviews.apache.org/r/35286/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Mark Wang
 




Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Mark Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
---

(Updated July 6, 2015, 6:45 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
---

Rename OptionT::get(const T _t) to getOrElse() and refactor original 
functions (libprocess)


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579 

Diff: https://reviews.apache.org/r/35286/diff/


Testing
---

make check


Thanks,

Mark Wang



Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Mark Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
---

(Updated July 6, 2015, 6:33 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
---

Rename OptionT::get(const T _t) to getOrElse() and refactor original 
functions (libprocess)


Diffs
-

  3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579 
  3rdparty/libprocess/src/subprocess.cpp 
5b41f0d88fcab93d51d5c503f69faccedc210868 

Diff: https://reviews.apache.org/r/35286/diff/


Testing
---

make check


Thanks,

Mark Wang



Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-06-24 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/#review89280
---

Ship it!


Ship It!

- Till Toenshoff


On June 20, 2015, 4:47 p.m., Mark Wang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35286/
 ---
 
 (Updated June 20, 2015, 4:47 p.m.)
 
 
 Review request for mesos and Joris Van Remoortere.
 
 
 Bugs: MESOS-2800
 https://issues.apache.org/jira/browse/MESOS-2800
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Rename OptionT::get(const T _t) to getOrElse() and refactor original 
 functions (libprocess)
 
 
 Diffs
 -
 
   3rdparty/libprocess/src/process.cpp 
 aadd7bb0ae12b93336900c76d8d5aaa4421ea198 
   3rdparty/libprocess/src/subprocess.cpp 
 f41f5e2a34788e31749eb996c8ab38ea45989068 
 
 Diff: https://reviews.apache.org/r/35286/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Mark Wang
 




Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-06-20 Thread Mark Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
---

(Updated June 20, 2015, 4:47 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
---

Rename OptionT::get(const T _t) to getOrElse() and refactor original 
functions (libprocess)


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 
  3rdparty/libprocess/src/subprocess.cpp 
f41f5e2a34788e31749eb996c8ab38ea45989068 

Diff: https://reviews.apache.org/r/35286/diff/


Testing
---

make check


Thanks,

Mark Wang



Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-06-10 Thread Mark Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
---

(Updated June 10, 2015, 8:12 a.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
---

Rename OptionT::get(const T _t) to getOrElse() and refactor original 
functions (libprocess)


Diffs
-

  3rdparty/libprocess/src/process.cpp aadd7bb0ae12b93336900c76d8d5aaa4421ea198 
  3rdparty/libprocess/src/subprocess.cpp 
f41f5e2a34788e31749eb996c8ab38ea45989068 

Diff: https://reviews.apache.org/r/35286/diff/


Testing
---

make check


Thanks,

Mark Wang