Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-23 Thread Ian Downes
On June 23, 2015, 11:01 a.m., Ian Downes wrote: Ship It! For the test error, are we not cleaning out /var/run/mesos/netns (correctly) between tests so we're trying to symlink container1 repeatedly? We should probably be storing these symlinks in a directory the test controls? - Ian

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
On June 18, 2015, 6:08 p.m., Niklas Nielsen wrote: A few high level comments: 1) Let's use an enum instead of an unstructured int to encode the namespaces 2) Let's get a test wired up 3) Think about Mac compatibility while introducing the enum :) - Added an enum that is protected by

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 22, 2015, 1:56 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88919 --- Ship it! include/mesos/slave/isolator.hpp (lines 78 - 104)

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88902 --- Hum, I don't see any change from r2 to r3? Did you upload the

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
On June 22, 2015, 10:23 p.m., Jie Yu wrote: Hum, I don't see any change from r2 to r3? Did you upload the correct diff? I accidentally committed the diffs into the dependent RR. Fixed now. Thanks! :) - Kapil --- This is an

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 22, 2015, 10:48 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 22, 2015, 10:20 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 23, 2015, 1:03 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-18 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88442 --- A few high level comments: 1) Let's use an enum instead of an