Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review97881 --- Ship it! Ship It! - Guangya Liu On 九月 4, 2015, 11:19 p.m., Micha

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Sept. 4, 2015, 11:19 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 12, 2015, 2:44 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: > > src/master/http.cpp, line 573 > > > > > > What is 'Nothing' here? > > Michael Park wrote: > The `Nothing` here comes from the result of `master->apply` which retu

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 7:12 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: > > src/master/http.cpp, line 534 > > > > > > I don't like the name 'flatten' :( > > > > Could you at least be more explicit about it (i.e., emphasize that > > '

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: > > src/master/http.cpp, line 573 > > > > > > What is 'Nothing' here? > > Michael Park wrote: > The `Nothing` here comes from the result of `master->apply` which retu

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: > > src/master/http.cpp, line 475 > > > > > > We typically use leading undescore for temp variables. The tailing > > underscore is for class members (following google sty

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 10:44 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 9:55 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 9:51 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review94154 --- Ship it! LGTM overall. Please address the remaining issues and comm

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 507 > > > > > > The code until this line is basically request validation and > > authorization. Though it's not how we do it now,

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated July 31, 2015, 9:56 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated July 28, 2015, 9:03 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 16, 2015, 2:54 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 447 > > > > > > Not directly related to endpoints, but to dynamic reservations in > > general. Do you think it makes sense to boo

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 515-516 > > > > > > It looks like we actually have the role, but it's buried in resources. > > Do you envision having resources

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 16, 2015, 2:54 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 447 > > > > > > Not directly related to endpoints, but to dynamic reservations in > > general. Do you think it makes sense to boo

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 507 > > > > > > The code until this line is basically request validation and > > authorization. Though it's not how we do it now,

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 16, 2015, 2:54 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, line 447 > > > > > > Not directly related to endpoints, but to dynamic reservations in > > general. Do you think it makes sense to boo

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated July 27, 2015, 11:30 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On July 13, 2015, 4:46 p.m., Alexander Rukletsov wrote: > > A high level question: do you think rescinding offers is a big deal for now? I don't believe it's a big deal for now because frameworks need to deal with rescinded offers regardless, and I imagine the frequency of operators using th

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review91889 --- src/master/http.cpp (line 447)

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review91472 --- A high level question: do you think rescinding offers is a big deal

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

> On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 749 > > > > > > I think reserve is too abstract and may collide with future actions > > (think quota). How about `/dynamic/rese

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 28, 2015, 8:36 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 28, 2015, 8:35 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 27, 2015, 2:23 a.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review89595 --- Patch looks great! Reviews applied: [35934, 35939, 35947, 35702] A

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 26, 2015, 10:56 p.m.) Review request for mesos, Adam B, Benjamin