Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-29 Thread Adam B
> On June 25, 2015, 7:30 p.m., Adam B wrote: > > Nice work! So, running the command as root first will guarantee that > > lt-mesos-executor exists before trying to run the task as the test-user > > `nobody`? We might be able to fix this in a cleaner way, but this looks > > good enough to me. J

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/#review89640 --- Patch looks great! Reviews applied: [35728] All tests passed. - M

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread haosdent huang
> On June 26, 2015, 2:30 a.m., Adam B wrote: > > Nice work! So, running the command as root first will guarantee that > > lt-mesos-executor exists before trying to run the task as the test-user > > `nobody`? We might be able to fix this in a cleaner way, but this looks > > good enough to me. J

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 27, 2015, 4:37 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 27, 2015, 4:37 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/#review89458 --- Ship it! Nice work! So, running the command as root first will guar

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/#review88771 --- Patch looks great! Reviews applied: [35728] All tests passed. - M

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 22, 2015, 11:34 a.m.) Review request for mesos and Adam B. Bugs

Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- Review request for mesos and Adam B. Repository: mesos Description --- F