Re: Review Request 35981: Added persistent volume user guide.

2015-07-07 Thread Jie Yu
> On June 30, 2015, 12:14 a.m., Adam B wrote: > > docs/persistent-volume.md, line 56 > > > > > > Can a volume/reservation created by one framework principal only be > > destroyed/unreserved by a framework scheduler usi

Re: Review Request 35981: Added persistent volume user guide.

2015-07-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review90698 --- Patch looks great! Reviews applied: [32982, 35981] All tests passe

Re: Review Request 35981: Added persistent volume user guide.

2015-07-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- (Updated July 7, 2015, 12:34 p.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 35981: Added persistent volume user guide.

2015-07-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review90681 --- docs/persistent-volume.md (line 76)

Re: Review Request 35981: Added persistent volume user guide.

2015-07-07 Thread Adam B
> On June 29, 2015, 5:14 p.m., Adam B wrote: > > docs/persistent-volume.md, line 169 > > > > > > There is no `volumes` field. Just a `resources` field, where each > > resource in the list must contain a `disk.volume`

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89867 --- Patch looks great! Reviews applied: [32982, 35981] All tests passe

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- (Updated June 30, 2015, 5:59 a.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Michael Park
> On June 30, 2015, 12:14 a.m., Adam B wrote: > > docs/persistent-volume.md, line 169 > > > > > > There is no `volumes` field. Just a `resources` field, where each > > resource in the list must contain a `disk.volume`

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- (Updated June 30, 2015, 5:50 a.m.) Review request for mesos, Adam B, Jie Yu, an

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Michael Park
> On June 29, 2015, 7:09 p.m., Jie Yu wrote: > > docs/persistent-volume.md, lines 23-24 > > > > > > We don't store 'principal' in DiskInfo yet. Maybe add a "coming soon" > > somewhere as well? I put it at the end actu

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89827 --- Nice work! Just a few cleanups and questions/clarifications. docs/

Re: Review Request 35981: Added persistent volume user guide.

2015-06-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89773 --- Ship it! LGTM overall! Thanks a lot, mpark! docs/persistent-volum

Re: Review Request 35981: Added persistent volume user guide.

2015-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89655 --- Patch looks great! Reviews applied: [32982, 35981] All tests passe

Review Request 35981: Added persistent volume user guide.

2015-06-27 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Bugs: MESOS-2405