Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review141490 --- Closing this review due to inactivity. Please see our

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-06 Thread haosdent huang
> On Oct. 6, 2015, 3:20 a.m., Cong Wang wrote: > > src/tests/containerizer/port_mapping_tests.cpp, line 270 > > > > > > traffic_invalid_via_loopback is not good either, because there is no > > traffic from an

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review101563 --- Or simply use 'tee -a' instead? Since it should not append

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Benjamin Mahler
Jie or Ian, can you shepherd this? On Sat, Oct 3, 2015 at 5:25 PM, Mesos ReviewBot wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36180/#review101422 >

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread haosdent huang
> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote: > > Or simply use 'tee -a' instead? Since it should not append anything to that > > file when nc receives nothing. tee -a aslo OK, but seems use different files would more clear? - haosdent

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Cong Wang
> On Oct. 6, 2015, 12:01 a.m., Cong Wang wrote: > > Or simply use 'tee -a' instead? Since it should not append anything to that > > file when nc receives nothing. > > haosdent huang wrote: > tee -a aslo OK, but seems use different files would more clear? I have no preference on either.

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/ --- (Updated Oct. 6, 2015, 3:13 a.m.) Review request for mesos, Adam B, Ian

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review101591 --- src/tests/containerizer/port_mapping_tests.cpp (line 270)

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/ --- (Updated Oct. 3, 2015, 4:52 p.m.) Review request for mesos, Adam B, Ian

Re: Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/#review101422 --- Patch looks great! Reviews applied: [36180] All tests passed. -

Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/ --- Review request for mesos and Adam B. Bugs: MESOS-2765