Re: Review Request 36404: Added support for peek() to process::io

2015-08-27 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 27, 2015, 9:24 a.m.) Review request for mesos, Joris Van

Re: Review Request 36404: Added support for peek() to process::io

2015-08-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96657 --- Patch looks great! Reviews applied: [36999, 36646, 36404] All

Re: Review Request 36404: Added support for peek() to process::io

2015-08-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 26, 2015, 10:19 p.m.) Review request for mesos, Joris Van

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96356 --- 3rdparty/libprocess/src/io.cpp (lines 36 - 37)

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review96342 --- 3rdparty/libprocess/include/process/io.hpp (line 145)

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 25, 2015, 10:17 p.m.) Review request for Joris Van Remoortere

Re: Review Request 36404: Added support for peek() to process::io

2015-08-25 Thread Artem Harutyunyan
On Aug. 25, 2015, 9:29 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/io.cpp, lines 274-286 https://reviews.apache.org/r/36404/diff/7/?file=1027739#file1027739line274 This is the old style, in the new style we just dupliate the file descriptor so that if someone closes the

Re: Review Request 36404: Added support for peek() to process::io

2015-08-17 Thread Artem Harutyunyan
On July 26, 2015, 6:18 a.m., Joris Van Remoortere wrote: 3rdparty/libprocess/src/tests/io_tests.cpp, line 377 https://reviews.apache.org/r/36404/diff/4/?file=1018378#file1018378line377 we can get rid of some of these literals by: s/3/sizeof(data)/ What do you think? I

Re: Review Request 36404: Added support for peek() to process::io

2015-08-05 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 5, 2015, 8:26 p.m.) Review request for mesos, Joris Van

Re: Review Request 36404: Added support for peek() to process::io

2015-08-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/#review93994 --- Patch looks great! Reviews applied: [36999, 36646, 36404] All

Re: Review Request 36404: Added support for peek() to process::io

2015-08-03 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 3, 2015, 11:30 a.m.) Review request for mesos, Joris Van

Re: Review Request 36404: Added support for peek() to process::io

2015-08-03 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated Aug. 3, 2015, 10:44 a.m.) Review request for mesos, Joris Van

Re: Review Request 36404: Added support for peek() to process::io

2015-07-21 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated July 21, 2015, 10:29 p.m.) Review request for mesos, Joris Van

Re: Review Request 36404: Added support for peek() to process::io

2015-07-10 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ --- (Updated July 10, 2015, 3:20 p.m.) Review request for mesos, Joris Van