Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

2015-07-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91928 --- Ship it! src/tests/scheduler_event_call_tests.cpp (line 91)

Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

2015-07-16 Thread Ben Mahler
On July 16, 2015, 6:20 p.m., Vinod Kone wrote: src/tests/scheduler_event_call_tests.cpp, line 91 https://reviews.apache.org/r/36494/diff/1/?file=1011987#file1011987line91 Can you add a comment here saying that you are simulating master sending the event? Hm.. I'll have to

Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

2015-07-16 Thread Vinod Kone
On July 16, 2015, 6:20 p.m., Vinod Kone wrote: src/tests/scheduler_event_call_tests.cpp, line 91 https://reviews.apache.org/r/36494/diff/1/?file=1011987#file1011987line91 Can you add a comment here saying that you are simulating master sending the event? Ben Mahler wrote:

Re: Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

2015-07-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/#review91819 --- src/sched/sched.cpp (lines 489 - 492)

Review Request 36494: Implemented the MESSAGE Event handler in the scheduler driver.

2015-07-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36494/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2910