Re: Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review167320 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On July 20, 2015, 4:21 a.m., Jihun Kang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36610/ > --- > > (Updated July 20, 2015, 4:21 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3085 > https://issues.apache.org/jira/browse/MESOS-3085 > > > Repository: mesos > > > Description > --- > > Add explicit syscall header file to linux fs > > > Diffs > - > > src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd > > > Diff: https://reviews.apache.org/r/36610/diff/1/ > > > Testing > --- > > > Thanks, > > Jihun Kang > >
Re: Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review134588 --- Is this patch still valid? Take a look at https://reviews.apache.org/r/46730 - Tomasz Janiszewski On Lip 20, 2015, 4:21 rano, Jihun Kang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36610/ > --- > > (Updated Lip 20, 2015, 4:21 rano) > > > Review request for mesos. > > > Bugs: MESOS-3085 > https://issues.apache.org/jira/browse/MESOS-3085 > > > Repository: mesos > > > Description > --- > > Add explicit syscall header file to linux fs > > > Diffs > - > > src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd > > Diff: https://reviews.apache.org/r/36610/diff/ > > > Testing > --- > > > Thanks, > > Jihun Kang > >
Re: Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review109255 --- Ship it! Ship It! - Zhiwei Chen On July 20, 2015, 12:21 p.m., Jihun Kang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36610/ > --- > > (Updated July 20, 2015, 12:21 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3085 > https://issues.apache.org/jira/browse/MESOS-3085 > > > Repository: mesos > > > Description > --- > > Add explicit syscall header file to linux fs > > > Diffs > - > > src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd > > Diff: https://reviews.apache.org/r/36610/diff/ > > > Testing > --- > > > Thanks, > > Jihun Kang > >
Re: Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review109277 --- Isn't SYS_xxx in sys/syscall.h instead of syscall.h? - Cong Wang On July 20, 2015, 4:21 a.m., Jihun Kang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36610/ > --- > > (Updated July 20, 2015, 4:21 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-3085 > https://issues.apache.org/jira/browse/MESOS-3085 > > > Repository: mesos > > > Description > --- > > Add explicit syscall header file to linux fs > > > Diffs > - > > src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd > > Diff: https://reviews.apache.org/r/36610/diff/ > > > Testing > --- > > > Thanks, > > Jihun Kang > >
Re: Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/#review92367 --- Patch looks great! Reviews applied: [36610] All tests passed. - Mesos ReviewBot On July 20, 2015, 4:21 a.m., Jihun Kang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/ --- (Updated July 20, 2015, 4:21 a.m.) Review request for mesos. Bugs: MESOS-3085 https://issues.apache.org/jira/browse/MESOS-3085 Repository: mesos Description --- Add explicit syscall header file to linux fs Diffs - src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd Diff: https://reviews.apache.org/r/36610/diff/ Testing --- Thanks, Jihun Kang
Review Request 36610: Add explicit syscall header file to linux fs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36610/ --- Review request for mesos. Bugs: MESOS-3085 https://issues.apache.org/jira/browse/MESOS-3085 Repository: mesos Description --- Add explicit syscall header file to linux fs Diffs - src/linux/fs.cpp ea0891e320154b85a21ed2d138c192821efae9cd Diff: https://reviews.apache.org/r/36610/diff/ Testing --- Thanks, Jihun Kang
