Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127733 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 8, 2016, 10:33 a.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127711 --- Fix it, then Ship it!

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127556 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 6, 2016, 4:38 p.m., haosdent huang wrote: > > src/examples/dynamic_reservation_framework.cpp, line 181 > > > > > > How about add a default for unexpected state? May just log the error > > status. > >

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 7, 2016, 11:23 a.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 7, 2016, 12:38 a.m., haosdent huang wrote: > > src/examples/dynamic_reservation_framework.cpp, line 181 > > > > > > How about add a default for unexpected state? May just log the error > > status.

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127337 --- src/Makefile.am (line 2038)

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127319 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 6, 2016, 4:19 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 69-70 > > > > > > Initialize these in member init list. > > > > ```cpp > > : ... > >

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, line 308 > > > > > > `static const Resources TASK_RESOURCES;` > > Klaus Ma wrote: > If we mark it `const`,

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 1:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 311-320 > > > > > > Conceptutally, `Try` is not something we pass around like this. A > > function

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review127088 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated April 5, 2016, 5:28 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, line 308 > > > > > > `static const Resources TASK_RESOURCES;` If we mark it `const`, we have to move the

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 311-320 > > > > > > Conceptutally, `Try` is not something we pass around like this. A > > function

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 350-364 > > > > > > We should be able to just use the ones in `src/tests/mesos.hpp`. I'd like to

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 --- src/examples/dynamic_reservation_framework.cpp (line 52)

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125297 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125230 --- ping @mcypark, would you help to review it again? - Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 22, 2016, 11:44 a.m.) Review request for mesos, Greg Mann,

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 17, 2016, 2:27 a.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 119 > > > > > > Could you clarify for me how the slave gets into the RESERVED state the > > first time? It

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 17, 2016, 2:27 a.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 119 > > > > > > Could you clarify for me how the slave gets into the RESERVED state the > > first time? It

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 18, 2016, 2:47 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 16, 2016, 6:27 p.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 119 > > > > > > Could you clarify for me how the slave gets into the RESERVED state the > > first time? It

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 17, 2016, 2:15 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 16, 2016, 2:32 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 16, 2016, 1:40 a.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 56 > > > > > > Is this true? It looks like we will launch multiple tasks on some > > slaves. It should be

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 16, 2016, 2:27 p.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 15, 2016, 5:40 p.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 42 > > > > > > Instead of using boost here, perhaps we could use members of the STL > > like `std::stoi` and

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review122307 --- Thanks Klaus, this is great! It will be awesome to have an

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On Feb. 23, 2016, 7:23 a.m., Joerg Schad wrote: > > src/tests/dynamic_reservation_framework_test.sh, line 30 > > > > > > Thy do we need this? Comparing to persistent_volume_framework_test.sh After implicit role,

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review17 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 6, 2016, 7:25 p.m.) Review request for mesos, Adam B, Greg

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Feb. 21, 2016, 9:49 p.m.) Review request for mesos and Michael Park.