Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

> On Sept. 14, 2015, 12:37 a.m., Qian Zhang wrote: > > src/master/master.cpp, lines 4131-4134 > > > > > > I think we have done this in Master::Http::maintenanceSchedule(), so > > why we do it again here? Maybe

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Sept. 14, 2015, 12:46 p.m.) Review request for mesos, Benjamin

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

> On Sept. 2, 2015, 10:04 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 138-141 > > > > > > Consider Doxygen-ification. I don't want to start another debate around "mixed vs not mixed doxygen

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review98790 --- src/master/master.cpp (lines 4131 - 4134)

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review98798 --- Ship it! Ship It! - Benjamin Hindman On Sept. 13, 2015, 8:33

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review97527 --- Ship it! include/mesos/master/allocator.hpp (lines 138 - 141)

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review96370 --- After the TimeSpec change: src/master/master.cpp (lines 4139 -

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

On Aug. 18, 2015, 9:33 p.m., Joseph Wu wrote: src/master/master.hpp, line 478 https://reviews.apache.org/r/37175/diff/3/?file=1043316#file1043316line478 Why is this return type `Nothing`, instead of `void`? It was `Nothing` as I was calling this function from the tests before. It

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Aug. 25, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review95783 --- Ship it! LGTM except for one little thing: src/master/master.hpp

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review95156 --- Ship it! src/master/master.hpp (line 475)

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

On Aug. 6, 2015, 7:15 p.m., Joseph Wu wrote: src/master/master.cpp, line 3874 https://reviews.apache.org/r/37175/diff/1/?file=1033487#file1033487line3874 Since Unavailability updates are done by the operator, we might want this method to take `Machines` (plural) or even an entire

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,