Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-14 Thread Joseph Wu
> On Sept. 14, 2015, 4:51 p.m., Qian Zhang wrote: > > src/tests/master_maintenance_tests.cpp, line 418 > > > > > > I checked v1/mesos.proto, and found regular offer also has > > unavailability: > > ``` > >

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review98964 --- src/tests/master_maintenance_tests.cpp (line 405)

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-13 Thread Joris Van Remoortere
> On Aug. 28, 2015, 8:49 p.m., Benjamin Hindman wrote: > > src/tests/master_maintenance_tests.cpp, line 97 > > > > > > Can we do this ASAP? Either now or already as an independent review on > > this chain so that we

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review98143 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m.,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-08-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-08-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review95802 --- Ship it! Ship It! - Guangya Liu On 八月 18, 2015, 6:58 p.m.,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-08-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review95788 --- Ship it! Ship It! - Joseph Wu On Aug. 18, 2015, 11:58 a.m.,

Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-08-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.