---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 28, 2015, 2:37 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96762
---
Ship it!
src/master/http.cpp (line 1407)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96649
---
Not a full review, mostly nit-picks. Will do a second pass.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96581
---
src/tests/maintenance.hpp (line 37)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96567
---
Not a full review, but stopping after the validation routines.
On Aug. 25, 2015, 6:46 p.m., Joris Van Remoortere wrote:
src/tests/maintenance.hpp, lines 78-79
https://reviews.apache.org/r/37325/diff/12/?file=1051209#file1051209line78
Why do we have to fall down to second percision here?
Can we take an OptionTimeSpec instead?
Is the
On Aug. 26, 2015, 12:03 p.m., Joris Van Remoortere wrote:
src/master/http.cpp, line 1448
https://reviews.apache.org/r/37325/diff/12/?file=1051203#file1051203line1448
I don't know if we require a new line here. I wouldn't mind one.
thoughts?
It'll run over 80 characters without
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 26, 2015, 2:16 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 26, 2015, 2:46 p.m.)
Review request for mesos, Benjamin Hindman,
On Aug. 26, 2015, 7:03 p.m., Joris Van Remoortere wrote:
src/master/maintenance.hpp, lines 26-27
https://reviews.apache.org/r/37325/diff/12/?file=1051204#file1051204line26
is this the right order?
I think this was the right order : ). With a newline in-between, it could have
On Aug. 26, 2015, 7:03 p.m., Joris Van Remoortere wrote:
src/master/maintenance.cpp, lines 55-69
https://reviews.apache.org/r/37325/diff/12/?file=1051205#file1051205line55
This code is an example of where we could benefit from a helper
function if we had a C++ wrapper for these
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 25, 2015, 10:03 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 25, 2015, 9:10 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96308
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 24, 2015, 6:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/#review96474
---
src/tests/maintenance.hpp (lines 78 - 79)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 24, 2015, 11:48 a.m.)
Review request for mesos, Benjamin
On Aug. 12, 2015, 10:31 a.m., Joseph Wu wrote:
src/master/maintenance.cpp, lines 126-130
https://reviews.apache.org/r/37325/diff/2/?file=1037747#file1037747line126
Note: Considering the machine field in the master's local state
(https://reviews.apache.org/r/37170/diff/2#0.8), it
17 matches
Mail list logo
