Re: Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-17 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/ --- (Updated Aug. 17, 2015, 9:56 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/#review95652 --- Ship it! Ship It! - Timothy Chen On Aug. 17, 2015, 9:56 p.m.,

Re: Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/#review95632 --- 3rdparty/libprocess/src/http.cpp (line 798)

Re: Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-13 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/#review95281 --- I wonder if we should add a test for this so that we can assert

Re: Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-13 Thread Jojy Varghese
On Aug. 13, 2015, 4:56 p.m., Anand Mazumdar wrote: I wonder if we should add a test for this so that we can assert that the fix works ? One easy way I can think about it, looking at the tests in process_tests.cpp ( you should be able to use the already existing

Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/ --- Review request for mesos, Anand Mazumdar and Timothy Chen. Bugs: MESOS-3251