Re: Review Request 37540: Add perf event API

> On Dec. 2, 2015, 10:13 a.m., Niklas Nielsen wrote: > > Ping - Cong, is there anything you need to close the last issues? :) > > Cong Wang wrote: > I was blocked at the second to the last issue above and switched to > something else, now I can think more about it. Thanks! Sweet! Let us

Re: Review Request 37540: Add perf event API

> On Dec. 2, 2015, 6:13 p.m., Niklas Nielsen wrote: > > Ping - Cong, is there anything you need to close the last issues? :) I was blocked at the second to the last issue above and switched to something else, now I can think more about it. Thanks! - Cong

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review108686 --- Ping - Cong, is there anything you need to close the last issues?

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review106926 --- src/linux/perf.cpp (line 514)

Re: Review Request 37540: Add perf event API

> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 792 > > > > > > so the semantics of this read() are a bit confusing. > > > > if the caller calls the read() back to back, they

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 30, 2015, 12:12 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37540: Add perf event API

> On Sept. 22, 2015, 12:37 a.m., Jie Yu wrote: > > src/linux/perf.cpp, lines 516-529 > > > > > > Should we use `__sync_synchronize` instead? Hmm, __sync_synchronize is documented as a full memory barrier, while we

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review100656 --- src/linux/perf.hpp (line 96)

Re: Review Request 37540: Add perf event API

> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote: > > src/linux/perf.hpp, line 110 > > > > > > put the braces on the same line. more importantly, do you actually need > > a default constructor? > > > >

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review99882 --- src/linux/perf.cpp (lines 515 - 528)

Re: Review Request 37540: Add perf event API

> On Sept. 15, 2015, 12:31 a.m., Vinod Kone wrote: > > my main question is regarding division of responsibilities between the > > wrapper class and the process class. Looks like opening the fd and mmaping > > is done by the wrapper and the rest by the process. Can everything be done > > by

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review98924 --- my main question is regarding division of responsibilities between

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, line 119 > > > > > > We use "_" prefix for continuation. Since this is just a private > > overload, I would remove "_". Compile failed

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, lines 84-89 > > > > > > Do we need this overload considering users can call the overload below? I think it is still useful, because the

Re: Review Request 37540: Add perf event API

> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 819 > > > > > > who can discard this future? finalize(). - Cong --- This is

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 4, 2015, 11:13 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review97548 --- src/linux/perf.hpp (line 71)

Re: Review Request 37540: Add perf event API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 2, 2015, 10:16 p.m.) Review request for mesos, Chi Zhang, Ian