Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 4:51 p.m.) Review request for mesos, Marco Massenzio

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96054 --- Ship it! Ship It! - Marco Massenzio On Aug. 21, 2015, 4:51

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
On Aug. 21, 2015, 6:14 p.m., Jie Yu wrote: src/tests/containerizer/rootfs.hpp, lines 111-126 https://reviews.apache.org/r/37684/diff/1/?file=1046779#file1046779line111 Can you combine the this loop with the loop below (like the following). Also, could you use 'realpath' here to

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 7:15 p.m.) Review request for mesos, Marco Massenzio

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96068 --- Ship it! Thanks src/tests/containerizer/rootfs.hpp (lines 111 -