Re: Review Request 37873: Add quiesce logic in allocator

2015-09-20 Thread Vinod Kone
> On Sept. 17, 2015, 9:42 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 1608 > > > > > > Needs a test for the scheduler driver. I've only see one for the http > > scheduler library. > > > > Also,

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-18 Thread Guangya Liu
> On 九月 17, 2015, 9:42 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 1608 > > > > > > Needs a test for the scheduler driver. I've only see one for the http > > scheduler library. > > > > Also, can

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99450 --- src/tests/mesos.hpp (line 1608)

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99445 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 247)

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 18, 2015, 3:55 a.m.) Review request for mesos, Alexander

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 16, 2015, 5:50 a.m.) Review request for mesos, Alexander

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-15 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99152 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 6, 2015, 2:40 a.m.,

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99069 --- Ship it! Ship It! - Vinod Kone On Sept. 6, 2015, 2:40 a.m.,

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99077 --- src/master/allocator/mesos/hierarchical.hpp (line 229)

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-12 Thread Robert Lacroix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review98758 --- Ship it! Ship It! - Robert Lacroix On Sept. 6, 2015, 2:40 a.m.,

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 6, 2015, 2:40 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 4, 2015, 12:06 p.m.) Review request for mesos, Alexander

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-04 Thread Robert Lacroix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97836 --- Ship it! Ship It! - Robert Lacroix On Sept. 4, 2015, 12:06

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-03 Thread Alexander Rukletsov
> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 153 > > > > > > Are we quiescing resources or rather offers? I think it should be > > called

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-03 Thread Guangya Liu
> On 八月 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 153 > > > > > > Are we quiescing resources or rather offers? I think it should be > > called `quiesceOffers`

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 4, 2015, 2:19 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97728 --- Patch looks great! Reviews applied: [37532, 37873] All tests

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97464 --- Using a ```RefusedFilter``` for this is not the right solution. The

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread Guangya Liu
> On 九月 2, 2015, 4:07 p.m., James Peach wrote: > > Using a ```RefusedFilter``` for this is not the right solution. The point > > of the suppress call is to have a cheap way to disable offers at a > > framework granularity. Adding a ```RefusedFilter``` for the total is not > > cheap. Filters

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread James Peach
> On Sept. 2, 2015, 4:07 p.m., James Peach wrote: > > Using a ```RefusedFilter``` for this is not the right solution. The point > > of the suppress call is to have a cheap way to disable offers at a > > framework granularity. Adding a ```RefusedFilter``` for the total is not > > cheap.

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-31 Thread James Peach
> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 909 > > > > > > We need to store the information that a framework is quiescing offers > > in a more memory

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-30 Thread Robert Lacroix
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97031 --- src/master/allocator/mesos/hierarchical.hpp (line 153)

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-30 Thread Guangya Liu
On 八月 30, 2015, 5:10 p.m., Robert Lacroix wrote: src/master/allocator/mesos/hierarchical.hpp, line 909 https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line909 We need to store the information that a framework is quiescing offers in a more memory efficient way.

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 八月 31, 2015, 1:23 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-30 Thread Guangya Liu
> On 八月 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 909 > > > > > > We need to store the information that a framework is quiescing offers > > in a more memory

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-30 Thread Robert Lacroix
On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: src/master/allocator/mesos/hierarchical.hpp, line 909 https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line909 We need to store the information that a framework is quiescing offers in a more memory efficient