Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review102266 --- Ship it! I've shipped this patch with the minor typos and style

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On 十月 12, 2015, 6:15 p.m., Michael Park wrote: > > I've shipped this patch with the minor typos and style fixes outlined below. Thanks Michael Park for the update ;-) - Guangya --- This is an automatically generated e-mail. To reply,

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101613 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101495 --- Ship it! This is looking very good now! Thanks for being patient

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101566 --- Ship it! Ship It! - haosdent huang On Oct. 6, 2015, 12:26

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 十月 6, 2015, 12:26 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 十月 4, 2015, 4:24 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review101429 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 25, 2015, 4:21 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote: > > Looking almost perfect! Really appreciate that you diligently address all > > the comments I throw into you and don't give up. > > > > While you're touching this file, I would say it makes sense to clean up > > everything we can in

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100628 --- Per AlexR, I'll review as a native speaker. General note: There

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100611 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote: > > include/mesos/master/allocator.hpp, line 54 > > > > > > I think you killed that line in previous versions of the review, why do > > you want to bring it

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 25, 2015, 5:22 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100652 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On Sept. 24, 2015, 9:35 a.m., Alexander Rukletsov wrote: > > include/mesos/master/allocator.hpp, lines 60-61 > > > > > > Not yours, but let's wrap all types and variable names in backticks "`" > > Guangya Liu

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review100393 --- Looking almost perfect! Really appreciate that you diligently

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99732 --- include/mesos/master/allocator.hpp (line 80)

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99734 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 21, 2015, 7:28 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99387 --- I've commented on some issues. Several patterns I would like to ask

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97895 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 8, 2015, 3:18 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97969 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97887 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 7, 2015, 1:15 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 7, 2015, 5:10 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On 九月 2, 2015, 6:14 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 92-93 > > > > > > These two @param's don't add much, so you could exclude them. > > > > I added comments like this

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 3, 2015, 4:05 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97610 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On 九月 1, 2015, 4:56 p.m., Alexander Rukletsov wrote: > > include/mesos/master/allocator.hpp, line 90 > > > > > > I think "register" is misleading. Allocator is notified that a new > > framework joins the cluster

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97394 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97297 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97294 --- include/mesos/master/allocator.hpp (lines 62 - 64)

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 1, 2015, 2:59 p.m.) Review request for mesos, Adam B, Alexander