Re: Review Request 38061: Corrected include order in master.hpp

2015-09-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97733 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 2, 2015, 4:34

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97565 --- Ship it! Ship It! - Guangya Liu On 九月 2, 2015, 4:34 p.m., Alexan

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Guangya Liu
> On 九月 2, 2015, 4:45 p.m., Guangya Liu wrote: > > src/master/master.hpp, line 34 > > > > > > Alex, can you please show more detail for why we need to move #include > > ? Does the correct order is sub grouping > > i

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97525 --- Patch looks great! Reviews applied: [38061] All tests passed. - M

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97493 --- Ship it! Ship It! - Joseph Wu On Sept. 2, 2015, 9:34 a.m., Alexa

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Alexander Rukletsov
> On Sept. 2, 2015, 4:45 p.m., Guangya Liu wrote: > > src/master/master.hpp, line 34 > > > > > > Alex, can you please show more detail for why we need to move #include > > ? Does the correct order is sub grouping >

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97475 --- src/master/master.hpp

Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript