Re: Review Request 38149: Add message_call_received metrics for master

2015-09-09 Thread Guangya Liu
> On 九月 9, 2015, 5:37 p.m., Vinod Kone wrote: > > What's the use case for this metric? For old style messages, we had per > > framework "messages_received" because it was used for rate limiting. I see there is a "// TODO(vinod): Add metrics for calls." in comments and also adding this metrics

Re: Review Request 38149: Add message_call_received metrics for master

2015-09-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98225 --- What's the use case for this metric? For old style messages, we had

Re: Review Request 38149: Add message_call_received metrics for master

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98150 --- Patch looks great! Reviews applied: [38149] All tests passed. - M

Review Request 38149: Add message_call_received metrics for master

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --