Re: Review Request 38244: Renamed Filter to OfferFilter.

2015-09-19 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38244/#review99681
---

Ship it!



src/master/allocator/mesos/hierarchical.hpp (line 191)


I see you adjusted this in a further review.



src/master/allocator/mesos/hierarchical.hpp (line 358)


Why did this get added? It isn't used. 
Further, this summary suggests we're only doing a rename, when hre we're 
changing the structure.



src/master/allocator/mesos/hierarchical.hpp (line 998)


See comment above.



src/master/allocator/mesos/hierarchical.hpp (lines 1024 - 1029)


``OfferFilter``
``HierarchicalAllocatorProcess::expire``



src/master/allocator/mesos/hierarchical.hpp (line 1302)


we can add a new line here.



src/master/allocator/mesos/hierarchical.hpp (line 1306)


line wrapping.



src/master/allocator/mesos/hierarchical.hpp (line 1308)


"Filtered offer with "



src/master/allocator/mesos/hierarchical.hpp (line 1311)


we can add a new line here.



src/master/allocator/mesos/hierarchical.hpp 


no need to remove this.


- Joris Van Remoortere


On Sept. 18, 2015, 10:55 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38244/
> ---
> 
> (Updated Sept. 18, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
> 
> Diff: https://reviews.apache.org/r/38244/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38244: Renamed Filter to OfferFilter.

2015-09-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38244/#review99650
---

Ship it!


Ship It!

- Guangya Liu


On 九月 18, 2015, 10:55 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38244/
> ---
> 
> (Updated 九月 18, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
> 
> Diff: https://reviews.apache.org/r/38244/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38244: Renamed Filter to OfferFilter.

2015-09-18 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38244/
---

(Updated Sept. 18, 2015, 3:55 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3346
https://issues.apache.org/jira/browse/MESOS-3346


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
3374d63b8311cf10b3108f56b7b167c12a9d7a37 

Diff: https://reviews.apache.org/r/38244/diff/


Testing
---


Thanks,

Artem Harutyunyan