Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

2015-09-19 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38246/#review99683
---

Ship it!



include/mesos/master/allocator.hpp (line 156)


Let's clarify why unavailableResources is added here.



include/mesos/master/allocator.hpp (line 160)


typo


- Joris Van Remoortere


On Sept. 18, 2015, 10:55 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38246/
> ---
> 
> (Updated Sept. 18, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   src/master/allocator/mesos/allocator.hpp 
> 171548b2017a0b97124f052c21345668e274d117 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38246/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

2015-09-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38246/#review99649
---

Ship it!


Ship It!

- Guangya Liu


On 九月 18, 2015, 10:55 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38246/
> ---
> 
> (Updated 九月 18, 2015, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   src/master/allocator/mesos/allocator.hpp 
> 171548b2017a0b97124f052c21345668e274d117 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38246/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

2015-09-18 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38246/
---

(Updated Sept. 18, 2015, 3:55 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3346
https://issues.apache.org/jira/browse/MESOS-3346


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
  src/master/allocator/mesos/allocator.hpp 
171548b2017a0b97124f052c21345668e274d117 
  src/master/allocator/mesos/hierarchical.hpp 
3374d63b8311cf10b3108f56b7b167c12a9d7a37 
  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 

Diff: https://reviews.apache.org/r/38246/diff/


Testing
---

make check


Thanks,

Artem Harutyunyan