Review Request 38481: Fix UUID::random compile error in OSX.

2015-09-18 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/
---

Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
Park.


Bugs: MESOS-3046
https://issues.apache.org/jira/browse/MESOS-3046


Repository: mesos


Description
---

Fix UUID::random compile error in OSX.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
67f1984e4f800cb82797f2cc71596e7c153c2641 

Diff: https://reviews.apache.org/r/38481/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38481: Fix UUID::random compile error in OSX.

2015-09-18 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99510
---

Ship it!


Assuming the mix of `thread local` and `static` work as advertised, this is a 
clean and elegant solution.


3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 34)


Add empty line here.


- Alexander Rojas


On Sept. 18, 2015, 11:02 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38481/
> ---
> 
> (Updated Sept. 18, 2015, 11:02 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3046
> https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UUID::random compile error in OSX.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 67f1984e4f800cb82797f2cc71596e7c153c2641 
> 
> Diff: https://reviews.apache.org/r/38481/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38481: Fix UUID::random compile error in OSX.

2015-09-18 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/
---

(Updated Sept. 18, 2015, 9:25 a.m.)


Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
Park.


Changes
---

Update according @Alexander Rojas reviews.


Bugs: MESOS-3046
https://issues.apache.org/jira/browse/MESOS-3046


Repository: mesos


Description
---

Fix UUID::random compile error in OSX.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
67f1984e4f800cb82797f2cc71596e7c153c2641 

Diff: https://reviews.apache.org/r/38481/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 38481: Fix UUID::random compile error in OSX.

2015-09-18 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99528
---

Ship it!


Ship It!

- Klaus Ma


On Sept. 18, 2015, 9:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38481/
> ---
> 
> (Updated Sept. 18, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3046
> https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UUID::random compile error in OSX.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 67f1984e4f800cb82797f2cc71596e7c153c2641 
> 
> Diff: https://reviews.apache.org/r/38481/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38481: Fix UUID::random compile error in OSX.

2015-09-18 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38481/#review99542
---

Ship it!


Ship It!

- Ben Mahler


On Sept. 18, 2015, 9:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38481/
> ---
> 
> (Updated Sept. 18, 2015, 9:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Ben Mahler, Klaus Ma, and Michael 
> Park.
> 
> 
> Bugs: MESOS-3046
> https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix UUID::random compile error in OSX.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> 67f1984e4f800cb82797f2cc71596e7c153c2641 
> 
> Diff: https://reviews.apache.org/r/38481/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>