Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

2015-09-18 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99640
---

Ship it!


Ship It!

- Guangya Liu


On 九月 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38496/
> ---
> 
> (Updated 九月 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a trivial devolve call for V1 Executor Protobuf -> 
> unversioned protobuf that can be used internally.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
> 
> Diff: https://reviews.apache.org/r/38496/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

2015-09-18 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99589
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38496/
> ---
> 
> (Updated Sept. 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a trivial devolve call for V1 Executor Protobuf -> 
> unversioned protobuf that can be used internally.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
> 
> Diff: https://reviews.apache.org/r/38496/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

2015-09-18 Thread Isabel Jimenez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/#review99614
---

Ship it!


Ship It!

- Isabel Jimenez


On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38496/
> ---
> 
> (Updated Sept. 18, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds a trivial devolve call for V1 Executor Protobuf -> 
> unversioned protobuf that can be used internally.
> 
> 
> Diffs
> -
> 
>   src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
>   src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 
> 
> Diff: https://reviews.apache.org/r/38496/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>



Review Request 38496: Added devolve operation for V1 Executor Protobuf

2015-09-18 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38496/
---

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907


Repository: mesos


Description
---

This change adds a trivial devolve call for V1 Executor Protobuf -> unversioned 
protobuf that can be used internally.


Diffs
-

  src/internal/devolve.hpp f03cac5ce93fead70122ae76d537867f958317fe 
  src/internal/devolve.cpp 6cace660ef81a82ffab8b86d70c364a0718cffda 

Diff: https://reviews.apache.org/r/38496/diff/


Testing
---

make check


Thanks,

Anand Mazumdar