Re: Review Request 38499: Tests for executor endpoint on agent

2015-09-21 Thread Isabel Jimenez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99789
---

Ship it!


Ship It!

- Isabel Jimenez


On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> ---
> 
> (Updated Sept. 18, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces basic validation tests for the Executor HTTP endpoint 
> on Agent.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
>   src/tests/executor_http_api_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38499/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38499: Tests for executor endpoint on agent

2015-09-21 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/
---

(Updated Sept. 21, 2015, 9:53 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907


Repository: mesos


Description
---

This change introduces basic validation tests for the Executor HTTP endpoint on 
Agent.


Diffs (updated)
-

  src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
  src/tests/executor_http_api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38499/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 38499: Tests for executor endpoint on agent

2015-09-21 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99833
---

Ship it!



src/tests/executor_http_api_tests.cpp (line 79)


s/then/than/



src/tests/executor_http_api_tests.cpp (line 295)


s/json/JSON/



src/tests/executor_http_api_tests.cpp (line 340)


s/json/JSON/



src/tests/executor_http_api_tests.cpp (line 361)


s/a non-supported/an un-supported/


- Vinod Kone


On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> ---
> 
> (Updated Sept. 18, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces basic validation tests for the Executor HTTP endpoint 
> on Agent.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
>   src/tests/executor_http_api_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38499/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 38499: Tests for executor endpoint on agent

2015-09-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99584
---


Patch looks great!

Reviews applied: [38496, 38497, 38499]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> ---
> 
> (Updated Sept. 18, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces basic validation tests for the Executor HTTP endpoint 
> on Agent.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
>   src/tests/executor_http_api_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38499/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 38499: Tests for executor endpoint on agent

2015-09-18 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/
---

Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.


Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907


Repository: mesos


Description
---

This change introduces basic validation tests for the Executor HTTP endpoint on 
Agent.


Diffs
-

  src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
  src/tests/executor_http_api_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38499/diff/


Testing
---

make check


Thanks,

Anand Mazumdar