Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 26, 2015, 6:08 a.m., Joris Van Remoortere wrote: > > hausdorff will follow up with a JIRA for preventing 32 bit builds: > > MESOS-3525 > > haosdent will follow up with better documentation for VsBuildCommand.bat I create a issue here. https://issues.apache.org/jira/browse/MESOS-3528

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review100729 --- Ship it! hausdorff will follow up with a JIRA for preventing 32 bi

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 9:46 a.m., Artem Harutyunyan wrote: > > > > haosdent huang wrote: > I don't think so. And Makefile.am also not follow the 80 characters limit. I'd rather have the Makefile.am fixed too. - Artem --- This is an a

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 242 > > > > > > This surpasses 80 character limit, is there a way to fix it here and > > elsewhere in th

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/ --- (Updated Sept. 25, 2015, 10:08 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 242 > > > > > > This surpasses 80 character limit, is there a way to fix it here and > > elsewhere in th

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 242 > > > > > > This surpasses 80 character limit, is there a way to fix it here and > > elsewhere in th

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote: > > I don't think so. And Makefile.am also not follow the 80 characters limit. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review100598 --- LGTM (- the lines that are too long). - Artem Harutyunyan On Sep

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review100596 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 207)

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/ --- (Updated Sept. 21, 2015, 6:14 p.m.) Review request for mesos, haosdent huang, A

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

> On Sept. 21, 2015, 6:08 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat, line 52 > > > > > > s/not/does not/ > > s/current/the current/ > > > > And a period at the end. I

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review99788 --- Ship it! Definitely looks a lot cleaner with the NOOP macro :) 3r

Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoorter