Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/#review101548 --- Ship it! Ship It! - Jie Yu On Oct. 3, 2015, 12:04 a.m., Ben

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/#review101540 --- LGTM! Nice tests! 3rdparty/libprocess/src/http.cpp (line 783)

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-05 Thread Ben Mahler
> On Oct. 5, 2015, 11 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/http.cpp, line 783 > > > > > > s/`socket_`/`_socket`/? > > > > underscore suffix makes it more look like a member (Google style).

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/ --- (Updated Oct. 2, 2015, 11:49 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-10-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/ --- (Updated Oct. 3, 2015, 12:04 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.

2015-09-30 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38608/ --- (Updated Oct. 1, 2015, 12:19 a.m.) Review request for mesos, Benjamin Hindman,