Re: Review Request 38625: Replace clone system call with os::clone

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100128
---


Patch looks great!

Reviews applied: [38639, 38625]

All tests passed.

- Mesos ReviewBot


On Sept. 23, 2015, 1:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> ---
> 
> (Updated Sept. 23, 2015, 1:25 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael 
> Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp 
> dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 
> 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> ---
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
---

(Updated Sept. 23, 2015, 1:25 a.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael 
Park, and Cong Wang.


Changes
---

Update according @jieyu's reviews.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Replace clone system call with os::clone.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp 
dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
---

sudo make -j8 check


Thanks,

haosdent huang

Re: Review Request 38625: Replace clone system call with os::clone

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100068
---


Patch looks great!

Reviews applied: [38639, 38625]

All tests passed.

- Mesos ReviewBot


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> ---
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael 
> Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp 
> dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 
> 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> ---
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100050
---

Ship it!



src/tests/containerizer/ns_tests.cpp (lines 169 - 171)


Maybe

```
pid_t pid = os::clone(
lambda::bind(&childGetns, NULL),
nstype.get() | SIGCHLD);
```



src/tests/containerizer/ns_tests.cpp (lines 223 - 225)


Ditto.


- Jie Yu


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> ---
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael 
> Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp 
> dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 
> 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> ---
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

[haosdent huang]

> On Sept. 22, 2015, 4:51 p.m., Cong Wang wrote:
> > Why not introduce a wrapper for clone() to hide the 'stack'?
> 
> haosdent huang wrote:
> Sure, let me update again.

@wangcong I finish update the patch. Could you help review this again? Thank 
you very much.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/#review100012
---


On Sept. 22, 2015, 6:52 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38625/
> ---
> 
> (Updated Sept. 22, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael 
> Park, and Cong Wang.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace clone system call with os::clone.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> fd0ffcf838a745ccd458d57821d358eceb85be26 
>   src/tests/containerizer/launch_tests.cpp 
> dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
>   src/tests/containerizer/ns_tests.cpp 
> 3a22938a31b717568d38090c57ca37e440e77274 
> 
> Diff: https://reviews.apache.org/r/38625/diff/
> 
> 
> Testing
> ---
> 
> sudo make -j8 check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38625: Replace clone system call with os::clone

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38625/
---

(Updated Sept. 22, 2015, 6:52 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, Michael 
Park, and Cong Wang.


Changes
---

Update desc.


Summary (updated)
-

Replace clone system call with os::clone


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description (updated)
---

Replace clone system call with os::clone.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
fd0ffcf838a745ccd458d57821d358eceb85be26 
  src/tests/containerizer/launch_tests.cpp 
dbe891cd004a8f8b4be252b1bd496fc5d4cc5923 
  src/tests/containerizer/ns_tests.cpp 3a22938a31b717568d38090c57ca37e440e77274 

Diff: https://reviews.apache.org/r/38625/diff/


Testing
---

sudo make -j8 check


Thanks,

haosdent huang