Re: Review Request 38630: Fixed order for header includes
> On Sept. 23, 2015, 7:02 p.m., Felix Abecassis wrote: > > Bad timing, this breaks the build because of > > https://reviews.apache.org/r/38517/ Ahh bummer, `make check` succeeded for me too may be it because it was able to find the header `common/attributes.hpp` in the build folder. Fixing it. - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100264 --- On Sept. 23, 2015, 6:13 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38630/ > --- > > (Updated Sept. 23, 2015, 6:13 p.m.) > > > Review request for mesos, Isabel Jimenez and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Trivial change to fix the include order for internal files noticed while > working on the Executor API > > > Diffs > - > > src/slave/slave.hpp 8fcd2d99eeda9138144520d6ab4a5bd8a5300f07 > > Diff: https://reviews.apache.org/r/38630/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38630: Fixed order for header includes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100264 --- Bad timing, this breaks the build because of https://reviews.apache.org/r/38517/ - Felix Abecassis On Sept. 23, 2015, 6:13 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38630/ > --- > > (Updated Sept. 23, 2015, 6:13 p.m.) > > > Review request for mesos, Isabel Jimenez and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Trivial change to fix the include order for internal files noticed while > working on the Executor API > > > Diffs > - > > src/slave/slave.hpp 8fcd2d99eeda9138144520d6ab4a5bd8a5300f07 > > Diff: https://reviews.apache.org/r/38630/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38630: Fixed order for header includes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/ --- (Updated Sept. 23, 2015, 6:13 p.m.) Review request for mesos, Isabel Jimenez and Vinod Kone. Changes --- Rebased Repository: mesos Description --- Trivial change to fix the include order for internal files noticed while working on the Executor API Diffs (updated) - src/slave/slave.hpp 8fcd2d99eeda9138144520d6ab4a5bd8a5300f07 Diff: https://reviews.apache.org/r/38630/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 38630: Fixed order for header includes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100250 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 4:16 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38630/ > --- > > (Updated Sept. 22, 2015, 4:16 p.m.) > > > Review request for mesos, Isabel Jimenez and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Trivial change to fix the include order for internal files noticed while > working on the Executor API > > > Diffs > - > > src/slave/slave.hpp 7a54fadcd7651352d01a0db0d802b9665806730a > > Diff: https://reviews.apache.org/r/38630/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 38630: Fixed order for header includes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/#review100013 --- Patch looks great! Reviews applied: [38630] All tests passed. - Mesos ReviewBot On Sept. 22, 2015, 4:16 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38630/ > --- > > (Updated Sept. 22, 2015, 4:16 p.m.) > > > Review request for mesos, Isabel Jimenez and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Trivial change to fix the include order for internal files noticed while > working on the Executor API > > > Diffs > - > > src/slave/slave.hpp 7a54fadcd7651352d01a0db0d802b9665806730a > > Diff: https://reviews.apache.org/r/38630/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Review Request 38630: Fixed order for header includes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38630/ --- Review request for mesos, Isabel Jimenez and Vinod Kone. Repository: mesos Description --- Trivial change to fix the include order for internal files noticed while working on the Executor API Diffs - src/slave/slave.hpp 7a54fadcd7651352d01a0db0d802b9665806730a Diff: https://reviews.apache.org/r/38630/diff/ Testing --- make check Thanks, Anand Mazumdar
