Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100231 --- Can we add this test to the relevant CMakeLists.txt too? - Alex

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Joseph Wu
> On Sept. 23, 2015, 10:37 a.m., Alex Clemmer wrote: > > Can we add this test to the relevant CMakeLists.txt too? It will be included :) See the not-discarded review: https://reviews.apache.org/r/38667 - Joseph --- This is an

Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-3499

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100150 --- 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp (line 68)

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/#review100151 --- Bad patch! Reviews applied: [38665] Failed command:

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38665/ --- (Updated Sept. 22, 2015, 11:38 p.m.) Review request for mesos, Joris Van

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68 > > > > > > what's the different between this and os::realpath? You're right, there is none. I'll

Re: Review Request 38665: Added fs::realpath().

2015-09-23 Thread Artem Harutyunyan
> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68 > > > > > > what's the different between this and os::realpath? > > Artem Harutyunyan wrote: >