Re: Review Request 38667: Added a test for os::realpath().

2015-09-27 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100785 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 26, 2015, 7:4

Re: Review Request 38667: Added a test for os::realpath().

2015-09-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100747 --- Patch looks great! Reviews applied: [38667] All tests passed. -

Re: Review Request 38667: Added a test for os::realpath().

2015-09-26 Thread Artem Harutyunyan
> On Sept. 25, 2015, 10:37 a.m., Joris Van Remoortere wrote: > > Can we simplify this by using: > > `os::mktemp` > > `os::stat::inode` to verify the `ino_t`? > > I know the files get removed after the tests finish running; however, if > > you use gtest_repeat this is a really easy way to fill up

Re: Review Request 38667: Added a test for os::realpath().

2015-09-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/ --- (Updated Sept. 26, 2015, 12:43 a.m.) Review request for mesos, Jie Yu, Joris Va

Re: Review Request 38667: Added a test for os::realpath().

2015-09-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100626 --- Can we simplify this by using: `os::mktemp` `os::stat::inode` to ve

Re: Review Request 38667: Added a test for os::realpath().

2015-09-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100222 --- Ship it! Ship It! - Joseph Wu On Sept. 23, 2015, 12:07 a.m., Ar

Re: Review Request 38667: Added a test for os::realpath().

2015-09-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/#review100164 --- Patch looks great! Reviews applied: [38667] All tests passed. -

Review Request 38667: Added a test for os::realpath().

2015-09-22 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38667/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Bugs: MESOS-3499