Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-26 Thread Alex Clemmer
> On Sept. 26, 2015, 6:10 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, line 82 > > > > > > Do we not need lflags for libevent? > > Alex Clemmer wrote: > The shor

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-26 Thread Alex Clemmer
> On Sept. 26, 2015, 6:10 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, line 82 > > > > > > Do we not need lflags for libevent? The short answer is that we didn't nee

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/#review100741 --- Ship it! 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/ --- (Updated Sept. 25, 2015, 10:11 p.m.) Review request for mesos, Artem Harutyunya

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/#review100615 --- LGTM. - Artem Harutyunyan On Sept. 24, 2015, 11:18 p.m., Alex Cl

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/#review100602 --- Looks good. Won't hurt to mention (in the description) that this n

Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

2015-09-24 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu