Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

2015-09-29 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38870/
---

(Updated Sept. 30, 2015, 12:36 a.m.)


Review request for mesos and Vinod Kone.


Repository: mesos


Description (updated)
---

Fixed a bug related to reviewboard_url option in post-reviews.py.

We append sys.argv[1:] to rbt post, and --reviewboard_url is not a valid option 
for rbt post.


Diffs
-

  support/post-reviews.py 78201ee79dc528a0cfdd0b89cc0a191be3d5846c 

Diff: https://reviews.apache.org/r/38870/diff/


Testing
---

Posted this review using
support/post-reviews.py --server=https://reviews.apache.org/


Thanks,

Jie Yu



Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

2015-09-29 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38870/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Fixed a bug related to reviewboard_url option in post-reviews.py.


Diffs
-

  support/post-reviews.py 78201ee79dc528a0cfdd0b89cc0a191be3d5846c 

Diff: https://reviews.apache.org/r/38870/diff/


Testing
---

Posted this review using
support/post-reviews.py --server=https://reviews.apache.org/


Thanks,

Jie Yu



Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

2015-09-29 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38870/#review101052
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 30, 2015, 12:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38870/
> ---
> 
> (Updated Sept. 30, 2015, 12:36 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a bug related to reviewboard_url option in post-reviews.py.
> 
> We append sys.argv[1:] to rbt post, and --reviewboard_url is not a valid 
> option for rbt post.
> 
> 
> Diffs
> -
> 
>   support/post-reviews.py 78201ee79dc528a0cfdd0b89cc0a191be3d5846c 
> 
> Diff: https://reviews.apache.org/r/38870/diff/
> 
> 
> Testing
> ---
> 
> Posted this review using
> support/post-reviews.py --server=https://reviews.apache.org/
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py.

2015-09-29 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38870/#review101068
---


Bad patch!

Reviews applied: [38870]

Failed command: ./support/apply-review.sh -n -r 38870

Error:
 2015-09-30 02:50:52 URL:https://reviews.apache.org/r/38870/diff/raw/ [954/954] 
-> "38870.patch" [1]
error: patch failed: support/post-reviews.py:98
error: support/post-reviews.py: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 30, 2015, 12:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38870/
> ---
> 
> (Updated Sept. 30, 2015, 12:36 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed a bug related to reviewboard_url option in post-reviews.py.
> 
> We append sys.argv[1:] to rbt post, and --reviewboard_url is not a valid 
> option for rbt post.
> 
> 
> Diffs
> -
> 
>   support/post-reviews.py 78201ee79dc528a0cfdd0b89cc0a191be3d5846c 
> 
> Diff: https://reviews.apache.org/r/38870/diff/
> 
> 
> Testing
> ---
> 
> Posted this review using
> support/post-reviews.py --server=https://reviews.apache.org/
> 
> 
> Thanks,
> 
> Jie Yu
> 
>