Re: Review Request 39192: Fixed leakage of fts_open.

2015-10-12 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39192/
---

(Updated Oct. 12, 2015, 8:18 p.m.)


Review request for mesos and Ben Mahler.


Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519


Repository: mesos


Description
---

Fixed leakage of fts_open.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 

Diff: https://reviews.apache.org/r/39192/diff/


Testing (updated)
---

make check


Thanks,

Chi Zhang

Re: Review Request 39192: Fixed leakage of fts_open.

2015-10-12 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39192/#review102314
---

Ship it!


Ship It!

- Ben Mahler


On Oct. 12, 2015, 8:18 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39192/
> ---
> 
> (Updated Oct. 12, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed leakage of fts_open.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/39192/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Review Request 39192: Fixed leakage of fts_open.

2015-10-09 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39192/
---

Review request for mesos and Ben Mahler.


Bugs: mesos-3519
https://issues.apache.org/jira/browse/mesos-3519


Repository: mesos


Description
---

Fixed leakage of fts_open.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 

Diff: https://reviews.apache.org/r/39192/diff/


Testing
---


Thanks,

Chi Zhang

Re: Review Request 39192: Fixed leakage of fts_open.

2015-10-09 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39192/#review102127
---



3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 243)


Can you preserve errno here and in the other cases you've touched?


- Ben Mahler


On Oct. 9, 2015, 10:10 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39192/
> ---
> 
> (Updated Oct. 9, 2015, 10:10 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed leakage of fts_open.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 
> 
> Diff: https://reviews.apache.org/r/39192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>