Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-17 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review103033
---

Ship it!



3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines 78 - 82)


Any reason not to keep these alphabetized?


- Joris Van Remoortere


On Oct. 15, 2015, 8:31 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> ---
> 
> (Updated Oct. 15, 2015, 8:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> f0de224b0d7924344fb1945b387b728a7241df87 
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 
> PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> 577aac82f527f3cce9f5b0cd24cc51091c311789 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 60108ff598fb075584196aa3d8e8e66e726c9f2a 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> d60bce237ec73f462fd373590a3589d554e76fc3 
> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-15 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/
---

(Updated Oct. 15, 2015, 8:31 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Moved libevent, gmock, http-parser to CMake on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
f0de224b0d7924344fb1945b387b728a7241df87 
  3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template PRE-CREATION 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
577aac82f527f3cce9f5b0cd24cc51091c311789 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
60108ff598fb075584196aa3d8e8e66e726c9f2a 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
d60bce237ec73f462fd373590a3589d554e76fc3 

Diff: https://reviews.apache.org/r/39202/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-13 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/
---

(Updated Oct. 13, 2015, 6:28 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Moved libevent, gmock, http-parser to CMake on Windows.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
f0de224b0d7924344fb1945b387b728a7241df87 
  3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template PRE-CREATION 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
ee1c74d31e28136bf289f4100d79a8ce568cd3af 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
60108ff598fb075584196aa3d8e8e66e726c9f2a 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
ea6db09e1a1aa01450aee93814e07f09feae7ac9 

Diff: https://reviews.apache.org/r/39202/diff/


Testing
---


Thanks,

Alex Clemmer



Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-13 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review102508
---

Ship it!



3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template (line 19)


Typo: s/compied/copied/


- Joseph Wu


On Oct. 13, 2015, 11:28 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> ---
> 
> (Updated Oct. 13, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> f0de224b0d7924344fb1945b387b728a7241df87 
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 
> PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> ee1c74d31e28136bf289f4100d79a8ce568cd3af 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 60108ff598fb075584196aa3d8e8e66e726c9f2a 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> ea6db09e1a1aa01450aee93814e07f09feae7ac9 
> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-12 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review102300
---



3rdparty/libprocess/3rdparty/CMakeLists.txt (line 124)


Templatize and rename upon copy.  (See comment below).



3rdparty/libprocess/3rdparty/CMakeLists.txt 


Where are you moving this to?
(Or why do we *not* need to build Gmock now?)



3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt (line 17)


Since you copy this file into its final destination, could you make this a 
template?

i.e. Rename to `CMakeLists.txt.template`.


- Joseph Wu


On Oct. 9, 2015, 9:36 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> ---
> 
> (Updated Oct. 9, 2015, 9:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> f0de224b0d7924344fb1945b387b728a7241df87 
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> ee1c74d31e28136bf289f4100d79a8ce568cd3af 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 60108ff598fb075584196aa3d8e8e66e726c9f2a 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> ea6db09e1a1aa01450aee93814e07f09feae7ac9 
> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-12 Thread Alex Clemmer


> On Oct. 12, 2015, 7:26 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 241-246
> > 
> >
> > Where are you moving this to?
> > (Or why do we *not* need to build Gmock now?)

Sorry, I didn't add a commit message here in my haste.

Basically: GMock 1.7 includes a new CMake-based build system as an option, 
alongside the VS solution. So we just use that instead of the VS solution. By 
ommitting a build command here we cause CMake to use its "default" behavior, 
which is to treat the project as a CMake project. In VS, this means 
specifically that GMock becomes "just another C++ project" embedded in the 
Mesos solution file. So it's very convenient.

And, btw, the reason we're doing this is because GMock's build is broken on 
Ubuntu 15 when you use autotools. So transitioning to CMake has the practical 
advantage of causing the build to work on Joris's machine.

As an action item, I will update the commit message to explain this. :) Does 
that sound good?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review102300
---


On Oct. 10, 2015, 4:36 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> ---
> 
> (Updated Oct. 10, 2015, 4:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> f0de224b0d7924344fb1945b387b728a7241df87 
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> ee1c74d31e28136bf289f4100d79a8ce568cd3af 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 60108ff598fb075584196aa3d8e8e66e726c9f2a 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> ea6db09e1a1aa01450aee93814e07f09feae7ac9 
> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-10 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review102157
---


Ah. Sorry about the reviewbot problem. I thought the dependency chain of 
reviews was updated when I pushed, but it wasn't.

- Alex Clemmer


On Oct. 10, 2015, 4:36 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> ---
> 
> (Updated Oct. 10, 2015, 4:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> f0de224b0d7924344fb1945b387b728a7241df87 
>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> ee1c74d31e28136bf289f4100d79a8ce568cd3af 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> 60108ff598fb075584196aa3d8e8e66e726c9f2a 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> ea6db09e1a1aa01450aee93814e07f09feae7ac9 
> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-09 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Moved libevent, gmock, http-parser to CMake on Windows.


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
f0de224b0d7924344fb1945b387b728a7241df87 
  3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt PRE-CREATION 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
ee1c74d31e28136bf289f4100d79a8ce568cd3af 
  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
60108ff598fb075584196aa3d8e8e66e726c9f2a 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
ea6db09e1a1aa01450aee93814e07f09feae7ac9 

Diff: https://reviews.apache.org/r/39202/diff/


Testing
---


Thanks,

Alex Clemmer