Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-12-12 Thread Joris Van Remoortere 
Actually we do:
https://github.com/apache/mesos/blob/master/src/master/quota_handler.cpp#L391

On Fri, Dec 11, 2015 at 12:23 AM, Alexander Rukletsov 
wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39288/
> src/master/quota_handler.cpp
>  
> (Diff
> revision 11)
>
> 19
>
> #include 
>
> Guys, we don't need vector here any more, let's remove it.
>
>
> - Alexander Rukletsov
>
> On December 4th, 2015, 1:51 p.m. UTC, Jan Schlicht wrote:
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van
> Remoortere, and Till Toenshoff.
> By Jan Schlicht.
>
> *Updated Dec. 4, 2015, 1:51 p.m.*
> *Bugs: * MESOS-3861 
> *Repository: * mesos
> Description
>
> Added authentication of quota requests.
>
> Testing
>
> make check
>
> Diffs
>
>- src/master/master.hpp (4683fa542a740f9a0b80fff7fbe0e63ec66266f2)
>- src/master/quota_handler.cpp
>(76de7c44c2cbd16c5f76b1dc0a94f567e037bffe)
>
> View Diff 
>

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-12-11 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39288/#review109930
---



src/master/quota_handler.cpp (line 19)


Guys, we don't need vector here any more, let's remove it.


- Alexander Rukletsov


On Dec. 4, 2015, 1:51 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39288/
> ---
> 
> (Updated Dec. 4, 2015, 1:51 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van 
> Remoortere, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3861
> https://issues.apache.org/jira/browse/MESOS-3861
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added authentication of quota requests.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
>   src/master/quota_handler.cpp 76de7c44c2cbd16c5f76b1dc0a94f567e037bffe 
> 
> Diff: https://reviews.apache.org/r/39288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-12-04 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39288/
---

(Updated Dec. 4, 2015, 2:51 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van 
Remoortere, and Till Toenshoff.


Changes
---

Address issues.


Bugs: MESOS-3861
https://issues.apache.org/jira/browse/MESOS-3861


Repository: mesos


Description
---

Added authentication of quota requests.


Diffs (updated)
-

  src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
  src/master/quota_handler.cpp 76de7c44c2cbd16c5f76b1dc0a94f567e037bffe 

Diff: https://reviews.apache.org/r/39288/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-11-11 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39288/
---

(Updated Nov. 11, 2015, 11:19 a.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Changes
---

Rebased.


Bugs: MESOS-3861
https://issues.apache.org/jira/browse/MESOS-3861


Repository: mesos


Description
---

Added authentication of quota requests.


Diffs (updated)
-

  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39288/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 39288: Quota: Added authentication of quota requests.

2015-11-10 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39288/
---

(Updated Nov. 10, 2015, 1:55 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
Toenshoff.


Bugs: MESOS-3861
https://issues.apache.org/jira/browse/MESOS-3861


Repository: mesos


Description
---

Added authentication of quota requests.


Diffs
-

  src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39288/diff/


Testing
---

make check


Thanks,

Jan Schlicht