Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3734

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102677 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2015, 6:14

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- (Updated Oct. 14, 2015, 6:26 p.m.) Review request for mesos and Joris Van

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- (Updated Oct. 14, 2015, 6:25 p.m.) Review request for mesos and Joris Van

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102694 --- Patch looks great! Reviews applied: [39323] All tests passed. -

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102709 --- Ship it! Ship It! - Gilbert Song On Oct. 14, 2015, 11:26 a.m.,

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102705 --- Ship it! Ship It! - Isabel Jimenez On Oct. 14, 2015, 6:26

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Neil Conway
> On Oct. 14, 2015, 11:24 p.m., James Peach wrote: > > Automake detects sed, so I think that you should do something like this: > > > > SED_I = $(SED) -i.orig > > > > foo: bar > > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@ I suppose there's value in using

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102718 --- Automake detects sed, so I think that you should do something like

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/ --- (Updated Oct. 14, 2015, 11:41 p.m.) Review request for mesos and Joris Van

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102727 --- Ship it! Ship It! - James Peach On Oct. 14, 2015, 11:41 p.m.,

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
> On Oct. 14, 2015, 11:24 p.m., James Peach wrote: > > Automake detects sed, so I think that you should do something like this: > > > > SED_I = $(SED) -i.orig > > > > foo: bar > > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@ > > Neil Conway wrote: > I

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102726 --- Ship it! Ship It! - James Peach On Oct. 14, 2015, 11:41 p.m.,

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102744 --- Patch looks great! Reviews applied: [39323] All tests passed. -