Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review104946 --- Ship it! Thanks! LGTM! src/log/consensus.cpp (line 46)

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Nov. 3, 2015, 7:13 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Nov. 2, 2015, 5:41 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Nov. 2, 2015, 7:42 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review104801 --- Patch looks great! Reviews applied: [39463, 39325] All tests

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review104389 --- Latest revision includes a new approach to setting up the unit

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 29, 2015, 4:50 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 29, 2015, 4:55 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-28 Thread Neil Conway
> On Oct. 23, 2015, 11:52 p.m., Jie Yu wrote: > > src/tests/log_tests.cpp, line 708 > > > > > > No snake_case please. Also, we try not to use tailing underscore for > > member fields if possible. Re: underscores,

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 29, 2015, 4:50 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review103873 --- Looks good to me except the last test. Looks quite ugly to me:(

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-23 Thread Neil Conway
> On Oct. 23, 2015, 11:52 p.m., Jie Yu wrote: > > Looks good to me except the last test. Looks quite ugly to me:( Still > > thinking about better solutions. > > > > The code part looks good to me, we can commit that first (with one more > > unit test to test the coordinator election logic

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 20, 2015, 8:45 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-16 Thread Neil Conway
> On Oct. 15, 2015, 12:31 a.m., Jie Yu wrote: > > src/messages/log.proto, line 148 > > > > > > I am just thinking about the rolling upgrade case. What happens if the > > old coordinator receives a response from a

Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 14, 2015, 8:29 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-14 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102693 --- src/tests/log_tests.cpp (line 730)

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102710 --- Haven't looked into details yet. Some high level questions below.

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Oct. 15, 2015, 1:21 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review102749 --- Patch looks great! Reviews applied: [39325] All tests passed. -