Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review104019 --- Ship it! Thanks for taking this on Greg! Greg will follow up with

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 21, 2015, 4:17 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103429 --- Patch looks great! Reviews applied: [39494] All tests passed. -

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103434 --- docs/configuration.md (line 1915)

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/ --- (Updated Oct. 21, 2015, 5:28 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103436 --- Ship it! Ship It! - Cong Wang On Oct. 21, 2015, 5:28 p.m.,

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Greg Mann
> On Oct. 21, 2015, 5:22 p.m., Cong Wang wrote: > > docs/configuration.md, line 1915 > > > > > > Like what you do for libevent, it would be nicer if you can add a URL > > to libnl3 too, but this is not a big

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103453 --- Patch looks great! Reviews applied: [39494] All tests passed. -