Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/#review104046 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/#review104357 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 27, 2015,

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-27 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/ --- (Updated Oct. 27, 2015, 6:31 a.m.) Review request for mesos, Artem

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-22 Thread Alex Clemmer
> On Oct. 22, 2015, 4:59 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp, lines 17-21 > > > > > > Nit: Can you flip the `#ifndef`? No need to negate the conditional if > >

Re: Review Request 39537: Windows: Moved `os::utime` to its own file, `stout/os/utime.hpp`.

2015-10-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39537/#review103599 --- Ship it! Confirmed that logic of `utime` did not change.